I prefer non-custodial staking, since it implies no risk to my funds. I have done savings too, there was local exchange which paid 12% interest for holding funds there, it worked fine as I held funds there for a long time until they stopped the offering.
You did not mention how much is staking return, that should help with the choice.
And as previously said, putting funds elsewhere implies risk, that's what you should keep in mind, do not chase huge returns without understanding risks.